fix(cli): Don't warn about hideLogs on some commands (#4813)

ionic-team · Jul 9, 2021 · dc279cc · dc279cc
1 parent 95c4756
commit dc279cc
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/cli/src/config.ts b/cli/src/config.ts
@@ -62,8 +62,6 @@ export async function loadConfig(): Promise<Config> {
     },
   };
 
-  checkExternalConfig(conf);
-
   debug('config: %O', config);
 
   return config;
@@ -446,7 +444,7 @@ const config: CapacitorConfig = ${formatJSObject(extConfig)};
 export default config;\n`;
 }
 
-function checkExternalConfig(config: ExtConfigPairs): void {
+export function checkExternalConfig(config: ExtConfigPairs): void {
   if (
     typeof config.extConfig.hideLogs !== 'undefined' ||
     typeof config.extConfig.android?.hideLogs !== 'undefined' ||

diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -1,7 +1,7 @@
 import program from 'commander';
 
 import c from './colors';
-import { loadConfig } from './config';
+import { checkExternalConfig, loadConfig } from './config';
 import type { Config } from './definitions';
 import { fatal, isFatal } from './errors';
 import { receive } from './ipc';
@@ -86,6 +86,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async (platform, { deployment }) => {
+          checkExternalConfig(config.app);
           const { syncCommand } = await import('./tasks/sync');
           await syncCommand(config, platform, deployment);
         }),
@@ -106,6 +107,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async (platform, { deployment }) => {
+          checkExternalConfig(config.app);
           const { updateCommand } = await import('./tasks/update');
           await updateCommand(config, platform, deployment);
         }),
@@ -118,6 +120,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async platform => {
+          checkExternalConfig(config.app);
           const { copyCommand } = await import('./tasks/copy');
           await copyCommand(config, platform);
         }),
@@ -161,6 +164,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async platform => {
+          checkExternalConfig(config.app);
           const { addCommand } = await import('./tasks/add');
           await addCommand(config, platform);
         }),
@@ -173,6 +177,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async platform => {
+          checkExternalConfig(config.app);
           const { listCommand } = await import('./tasks/list');
           await listCommand(config, platform);
         }),
@@ -185,6 +190,7 @@ export function runProgram(config: Config): void {
     .action(
       wrapAction(
         telemetryAction(config, async platform => {
+          checkExternalConfig(config.app);
           const { doctorCommand } = await import('./tasks/doctor');
           await doctorCommand(config, platform);
         }),