fix(android): removes setOnExitAnimationListener when fade out is disabled #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled to prevent crashes on OnePlus and Oppo devices on hide
ItsChaceD
requested review from
jcesarmobile,
IT-MikeS,
alexgerardojacinto,
hectorjdgdev,
OS-ricardomoreirasilva and
OS-martacarlos
|
Released dev build of splash-screen with dev version: 6.0.1-dev-2083-20240425T174342.0 |
OS-martacarlos
approved these changes
Apr 18, 2024
IT-MikeS
approved these changes
Apr 18, 2024
|
Only comment would be to also make this patch on 5.X as we'll have lots of people not on 6 for a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1856
This PR removes
setOnExitAnimationListenerwhen fade out is disabled to prevent crashes on OnePlus and Oppo devices on hideThis bug can also be reproduced by using a Pixel device running Android 12 by backgrounding the app during the app launch and waiting 10 seconds.