feat(google-maps): Add map instance getter - getRawGoogleMapInstance #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasWestrelin
changed the title
ThomasWestrelin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a getRawGoogleMapInstance method that exposes the underlying google.maps.Map instance when on web platforms.
This is especially useful when one wants to access specific features that are only available in the Google Map JS SDK or that haven't been implemented by this plugin. This provides an escape hatch that allows users to access all JS SDK features when those are only needed on web platforms, the only current workaround would be conditionally using this plugin to instead use the raw JS SDK on web platforms.
Context
We are migrating an existing app to Capacitor and are using advanced features from the JS SDK that cannot be implemented with the current interface. We don't need those advanced features in the native version of our app se we are fine to have them work only on the web.