Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TT-230 implement datepicker safari on Reports #671

Merged
merged 2 commits into from Apr 29, 2021

Conversation

LEON12699
Copy link
Member

datepicker on reports

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #671 (a7ff703) into master (13de42e) will increase coverage by 1.15%.
The diff coverage is 94.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   93.09%   94.25%   +1.15%     
==========================================
  Files          85      104      +19     
  Lines        1564     2053     +489     
  Branches      107      145      +38     
==========================================
+ Hits         1456     1935     +479     
- Misses         67       76       +9     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...nents/time-range-form/time-range-form.component.ts 100.00% <ø> (ø)
...er-management/store/customer-management.effects.ts 83.78% <14.28%> (-16.22%) ⬇️
...ared/components/input-date/input-date.component.ts 64.28% <50.00%> (-4.95%) ⬇️
...time-entries-table/time-entries-table.component.ts 61.90% <60.00%> (+6.34%) ⬆️
src/app/modules/user/store/user.reducer.ts 62.50% <62.50%> (ø)
...-management/store/activity-management.selectors.ts 77.77% <66.66%> (-9.73%) ⬇️
src/app/modules/user/services/user-info.service.ts 66.66% <66.66%> (ø)
src/app/modules/user/services/user.service.ts 75.00% <75.00%> (ø)
...dules/time-entries/pages/time-entries.component.ts 85.33% <82.60%> (+2.52%) ⬆️
...es-management/store/activity-management.effects.ts 94.59% <83.33%> (-5.41%) ⬇️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2126f...a7ff703. Read the comment docs.

@LEON12699 LEON12699 requested review from scastillo-jp, eduardisrael and thegreatyamori and removed request for thegreatyamori April 26, 2021 20:30
Copy link
Collaborator

@thegreatyamori thegreatyamori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, just check what's going on with the CI to make sure everything is correct.

@scastillo-jp scastillo-jp merged commit 70fc1eb into master Apr 29, 2021
@scastillo-jp scastillo-jp deleted the TT-230-Safari-datepicker-Reports branch April 29, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants