-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pyproject.toml
and setup.cfg
, updating setup.py
#53
Conversation
Desc. As part of the objective of the project we are moving from setup.py to pyproject.toml and setup.cfg
If we move the build backend to Flit then that will help us reduce two dependencies, |
@ayushanand18 I'm OK with Let me elaborate on the latter. Keeping the name in a The version management with setuptools-scm, see https://github.com/ioos/erddapy/blob/main/setup.py#L7-L12 for an example, is super handy b/c we need only to create tags and everything else is automated. I don't want to impose a workflow, just wanted to give my 2-cents here. If both you and @7yl4r agree go ahead with the pyproject.toml only approach, if you want to change I can help you out to adequate to my workflow. |
So I am moving back to setuptools for the time being because we will be using setup.py and setup.cfg. |
Python packaging can be a bit disappointing and I really wished we could use a single tool. Hopefully pyproject.toml + build will be it in the near future. |
I feel like it's true for every technology, every few years it evolves so much that the thing which seemed to be the future after some years it would look as if obsolete. I personally feel to be going back to books every day :) the more I see things the more I realize I'll need to learn more. But it's a beautiful journey overall! |
Update: I have updated the |
I like your enthusiasm in order to keep that, stay away from packaging ;-p |
pyproject.toml
from setup.py
pyproject.toml
and setup.cfg
, updating setup.py
That's been my strategy. 🤣 |
Overview
This PR aims to migrate from
setup.py
topyproject.toml
. Trying to resolve #16.Notes for reviewers
I figured that some projects used only
pyproject.toml
and completely did away withsetup.py
/setup.cfg
. It seems setuptools doesn't yet support PEP 660 so building editable installs withpyproject.toml
alone will throw errors (as in workflow runs). So I have moved to Flit as the build backend.Please review the details in the TOML file and advise me if I should add or remove anything.