Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new built-in format #44

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add new built-in format #44

wants to merge 4 commits into from
+136 −2

Conversation

haoel
Copy link

@haoel haoel commented Sep 8, 2022

samlown
samlown requested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@samlown samlown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense, but I do think we should have some tests to validate these use-cases.

@samlown samlown added the needs tests Not enough tests for this to be accepted label Sep 29, 2022
@samlown
Copy link
Contributor

samlown commented Nov 8, 2022

Thanks for the tests! Looks great! Just a few linting issues.

@haoel
Copy link
Author

haoel commented Nov 10, 2022

done!

@webdestroya
Copy link
Contributor

shouldn't it be BuiltInFormat rather than BuildInFormat ?

@haoel
Copy link
Author

haoel commented Nov 15, 2022

please approve running the workflows, I believe I fix the lint errors.

@amiramw
Copy link

amiramw commented Jun 8, 2023

is there a plan to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlown samlown samlown requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs tests Not enough tests for this to be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haoel @samlown @webdestroya @amiramw