Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Go comments from "main" package too #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Extract Go comments from "main" package too #133

wants to merge 1 commit into from

Commits on Feb 6, 2024

  1. Extract Go comments from "main" package too 

    ExtractGoComments() uses the fully-qualified package path when creating
keys in our CommentMap, but we perform lookups in that map using keys
constructed using (reflect.Type)PkgPath(). The latter method always
returns "main" for types defined in the "main" package, rather than a
fully-qualified package path, so those lookups fail. The result is that
we never incorporate comments into a schema for types defined in "main".

Update ExtractGoComments() to handle the special case of "main".
    @vzxv
    vzxv committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    df70a74 View commit details
    Browse the repository at this point in the history