feat(app)!: ios-sdk 10.25.0 (Xcode 15.2+) / android-sdk 33 (minSdk21 + 23 for auth / compileSdk 34+) #7774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
82bfe97
to
1c82c9a
Compare
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
c176364
to
a77d8f0
Compare
|
This one has everything working except a hang in the iOS messaging e2e that may be the #7272 issue |
mikehardy
added
the
Workflow: Needs Review
mikehardy
changed the title
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
03f43e9
to
4ed5e7f
Compare
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
4ed5e7f
to
65dc001
Compare
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
65dc001
to
2051ca8
Compare
mikehardy
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7774 +/- ##
===========================================
+ Coverage 23.52% 69.87% +46.36%
===========================================
Files 134 150 +16
Lines 5570 5984 +414
Branches 1258 1255 -3
===========================================
+ Hits 1310 4181 +2871
+ Misses 3572 1714 -1858
+ Partials 688 89 -599 |
mikehardy
removed
the
Workflow: Needs Review
This was referenced May 8, 2024
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
0153105
to
823b377
Compare
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
823b377
to
61585d2
Compare
8 tasks
BREAKING CHANGE: firebase-ios-sdk 10.25.0 requires minimum Xcode 15.2+ This transitively requires macOS Ventura 13.5+ - for old hardware you may investigate OCLP (OpenCore Legacy Patcher) to update macOS to current versions and access newer Xcode versions
note that this would only be used if you built the module directly, that is, not in the context of an app, so no one would notice this change in practice / normal usage
there was only one usage of Guava in firestore, and it was easily replaced with a for loop which eliminates the dependency this is important in the context of firebase-android-sdk where guava is no longer transitively available - best to remove it here as well vs bring it in directly as a dependency we specifically we need
…uth) BREAKING CHANGE: - requires minSdk 21+ in general, 23+ for auth module - requires compileSdk 34+ - app-distribution gradle plugin requires - gradle 7.3+ - android gradle plugin 7+ - google services plugin 4.3.2+ - crashlytics plugin requires - gradle 8+ - android gradle plugin 8.1+ - google services plugin 4.4.1+
mikehardy
force-pushed
the
@mikehardy/dependency-updates
branch
from
61585d2
to
2057e38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adopt firebase-ios-sdk 10.25.0
Adopt firebase-android-sdk 33.0.0
Related issues
Continues to help with iOS privacy requirements from Apple
Lots of new goodies in android that we can expose here later, and lots of transitive deps updated
Release Summary
Has breaking changes commit snecessary for conventional-commits / semantic release but the important bits are:
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Run e2e tests locally, ensure they pass
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter