-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heating scheduler #37
Changes from all commits
42c7905
68a395e
b596c34
8d9f8d4
d1825b2
bc86f3f
4fb95e2
9576e6d
3ae2b81
ea8f54c
f879943
e97ac8e
67ee878
88995e5
b6abf52
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,6 @@ __pycache__ | |
# Coverage | ||
/coverage.xml | ||
/.coverage | ||
|
||
# Jupyter | ||
.ipynb_checkpoints |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,12 +9,19 @@ pylama = "*" | |
pre-commit = "*" | ||
coverage = "*" | ||
pytest-cov = "*" | ||
pipenv-setup = "*" | ||
iolite = {editable = true,path = "."} | ||
black = "==19.10b0" | ||
toml = "*" | ||
responses = "*" | ||
isort = "==4.3.21" | ||
pipenv-setup = "*" | ||
pytest-socket = "*" | ||
freezegun = "*" | ||
|
||
[packages] | ||
websockets = "*" | ||
environs = "*" | ||
requests = "*" | ||
|
||
[pipenv] | ||
allow_prereleases = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why was this declared? Do we really need pre-release dependencies? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Black is only available as a pre-release package and pipenv does not install pre-releases without actively allowing it to do so. When installing it with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the need for Which is also called on CI There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Having black, isort, and flake8 installed in the environment, I use file watchers to run them on every file save. I prefer this setup to running the pre-commit hook once in a while, because I immediately see the changes made by black and isort. Also, this way I can fix the flake8 warnings right away. I could probably also just run the pre-commit hook, this feels slightly slower, though (and runs on all files, not just the file I am working on). So I added the scripts as dev dependencies, cause I though it does no harm 🙂 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okays - that makes sense. I think pre-commit runs on the diff by default but you can also tell it to run on all changes. We can always remove the dev dependencies if it becomes too much. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to declare this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the example.py threw an error because iolite was not an installed package. So I added the iolite directory as an editable dev-dependency. This way you can
import iolite
without having the package actually installed in the environment.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh now I see it. It feels weird having the package add itself as a dependency but I am not sure of a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another solution would be to turn
scripts
into a module (add__init__.py
) and then it can be invoked aspython -m scripts.example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would work for the scripts, yes. I just realized the
iolite = {editable = true,path = "."}
is also needed to import iolite inside the notebooks, though. So I would like to keep this change.