Skip to content

When parsing owner/repo fallback to parsing 'origin' #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 23, 2020

What Changed

Set up a default for owner/repo when not found from package manager plugin.

Why

This is a nice fallback. Removes a required setup step (still recommended to configure repo in package manager)

Todo:

  • Add tests
  • Add docs
📦 Published PR as canary version: under canary scope @auto-canary@9.13.0-canary.975.12718.0

✨ Test out this PR locally via:

npm install @auto-canary/auto@9.13.0-canary.975.12718.0
npm install @auto-canary/core@9.13.0-canary.975.12718.0
npm install @auto-canary/all-contributors@9.13.0-canary.975.12718.0
npm install @auto-canary/chrome@9.13.0-canary.975.12718.0
npm install @auto-canary/conventional-commits@9.13.0-canary.975.12718.0
npm install @auto-canary/crates@9.13.0-canary.975.12718.0
npm install @auto-canary/first-time-contributor@9.13.0-canary.975.12718.0
npm install @auto-canary/git-tag@9.13.0-canary.975.12718.0
npm install @auto-canary/gradle@9.13.0-canary.975.12718.0
npm install @auto-canary/jira@9.13.0-canary.975.12718.0
npm install @auto-canary/maven@9.13.0-canary.975.12718.0
npm install @auto-canary/npm@9.13.0-canary.975.12718.0
npm install @auto-canary/omit-commits@9.13.0-canary.975.12718.0
npm install @auto-canary/omit-release-notes@9.13.0-canary.975.12718.0
npm install @auto-canary/released@9.13.0-canary.975.12718.0
npm install @auto-canary/s3@9.13.0-canary.975.12718.0
npm install @auto-canary/slack@9.13.0-canary.975.12718.0
npm install @auto-canary/twitter@9.13.0-canary.975.12718.0
npm install @auto-canary/upload-assets@9.13.0-canary.975.12718.0
# or 
yarn add @auto-canary/auto@9.13.0-canary.975.12718.0
yarn add @auto-canary/core@9.13.0-canary.975.12718.0
yarn add @auto-canary/all-contributors@9.13.0-canary.975.12718.0
yarn add @auto-canary/chrome@9.13.0-canary.975.12718.0
yarn add @auto-canary/conventional-commits@9.13.0-canary.975.12718.0
yarn add @auto-canary/crates@9.13.0-canary.975.12718.0
yarn add @auto-canary/first-time-contributor@9.13.0-canary.975.12718.0
yarn add @auto-canary/git-tag@9.13.0-canary.975.12718.0
yarn add @auto-canary/gradle@9.13.0-canary.975.12718.0
yarn add @auto-canary/jira@9.13.0-canary.975.12718.0
yarn add @auto-canary/maven@9.13.0-canary.975.12718.0
yarn add @auto-canary/npm@9.13.0-canary.975.12718.0
yarn add @auto-canary/omit-commits@9.13.0-canary.975.12718.0
yarn add @auto-canary/omit-release-notes@9.13.0-canary.975.12718.0
yarn add @auto-canary/released@9.13.0-canary.975.12718.0
yarn add @auto-canary/s3@9.13.0-canary.975.12718.0
yarn add @auto-canary/slack@9.13.0-canary.975.12718.0
yarn add @auto-canary/twitter@9.13.0-canary.975.12718.0
yarn add @auto-canary/upload-assets@9.13.0-canary.975.12718.0

Sorry, something went wrong.

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Feb 23, 2020
@hipstersmoothie hipstersmoothie force-pushed the repo-fallback branch 2 times, most recently from 6ed7478 to 99569fb Compare February 23, 2020 00:47
@codecov
Copy link

codecov bot commented Feb 23, 2020

Codecov Report

Merging #975 into master will decrease coverage by 0.08%.
The diff coverage is 79.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   80.39%   80.31%   -0.09%     
==========================================
  Files          40       41       +1     
  Lines        3065     3083      +18     
  Branches      621      661      +40     
==========================================
+ Hits         2464     2476      +12     
- Misses        437      439       +2     
- Partials      164      168       +4
Impacted Files Coverage Δ
plugins/npm/src/package-config.ts 90.9% <100%> (-9.1%) ⬇️
packages/core/src/auto.ts 77.5% <62.5%> (-0.26%) ⬇️
plugins/npm/src/index.ts 73.2% <66.66%> (-0.13%) ⬇️
packages/core/src/utils/get-repository.ts 90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4774956...c0953ea. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 8ba2fed into master Feb 23, 2020
@hipstersmoothie hipstersmoothie deleted the repo-fallback branch February 23, 2020 06:32
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.13.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants