Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter out bots in first-time contributor plugins #961

Merged
merged 1 commit into from Feb 18, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 18, 2020

What Changed

see title

Why

we don't need to thank renovate that much

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.10.7-canary.961.12548.0

✨ Test out this PR locally via:

npm install @auto-canary/auto@9.10.7-canary.961.12548.0
npm install @auto-canary/core@9.10.7-canary.961.12548.0
npm install @auto-canary/all-contributors@9.10.7-canary.961.12548.0
npm install @auto-canary/chrome@9.10.7-canary.961.12548.0
npm install @auto-canary/conventional-commits@9.10.7-canary.961.12548.0
npm install @auto-canary/crates@9.10.7-canary.961.12548.0
npm install @auto-canary/first-time-contributor@9.10.7-canary.961.12548.0
npm install @auto-canary/git-tag@9.10.7-canary.961.12548.0
npm install @auto-canary/gradle@9.10.7-canary.961.12548.0
npm install @auto-canary/jira@9.10.7-canary.961.12548.0
npm install @auto-canary/maven@9.10.7-canary.961.12548.0
npm install @auto-canary/npm@9.10.7-canary.961.12548.0
npm install @auto-canary/omit-commits@9.10.7-canary.961.12548.0
npm install @auto-canary/omit-release-notes@9.10.7-canary.961.12548.0
npm install @auto-canary/released@9.10.7-canary.961.12548.0
npm install @auto-canary/s3@9.10.7-canary.961.12548.0
npm install @auto-canary/slack@9.10.7-canary.961.12548.0
npm install @auto-canary/twitter@9.10.7-canary.961.12548.0
npm install @auto-canary/upload-assets@9.10.7-canary.961.12548.0
# or 
yarn add @auto-canary/auto@9.10.7-canary.961.12548.0
yarn add @auto-canary/core@9.10.7-canary.961.12548.0
yarn add @auto-canary/all-contributors@9.10.7-canary.961.12548.0
yarn add @auto-canary/chrome@9.10.7-canary.961.12548.0
yarn add @auto-canary/conventional-commits@9.10.7-canary.961.12548.0
yarn add @auto-canary/crates@9.10.7-canary.961.12548.0
yarn add @auto-canary/first-time-contributor@9.10.7-canary.961.12548.0
yarn add @auto-canary/git-tag@9.10.7-canary.961.12548.0
yarn add @auto-canary/gradle@9.10.7-canary.961.12548.0
yarn add @auto-canary/jira@9.10.7-canary.961.12548.0
yarn add @auto-canary/maven@9.10.7-canary.961.12548.0
yarn add @auto-canary/npm@9.10.7-canary.961.12548.0
yarn add @auto-canary/omit-commits@9.10.7-canary.961.12548.0
yarn add @auto-canary/omit-release-notes@9.10.7-canary.961.12548.0
yarn add @auto-canary/released@9.10.7-canary.961.12548.0
yarn add @auto-canary/s3@9.10.7-canary.961.12548.0
yarn add @auto-canary/slack@9.10.7-canary.961.12548.0
yarn add @auto-canary/twitter@9.10.7-canary.961.12548.0
yarn add @auto-canary/upload-assets@9.10.7-canary.961.12548.0

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #961 into master will increase coverage by 0.06%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   80.33%   80.39%   +0.06%     
==========================================
  Files          40       40              
  Lines        3030     3030              
  Branches      646      612      -34     
==========================================
+ Hits         2434     2436       +2     
+ Misses        435      434       -1     
+ Partials      161      160       -1
Impacted Files Coverage Δ
packages/core/src/log-parse.ts 100% <ø> (ø) ⬆️
plugins/first-time-contributor/src/index.ts 87.09% <50%> (+6.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8708a...d76d0ba. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 0fc21b5 into master Feb 18, 2020
@hipstersmoothie hipstersmoothie deleted the first-time branch February 18, 2020 16:44
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.10.7 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants