Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rare issue with canary id from git sha #2448

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix rare issue with canary id from git sha #2448

merged 2 commits into from
Apr 3, 2024

Commits on Apr 2, 2024

  1. In the rare case that the first 7 characters of a git sha contains on… 

    …ly numbers and begins with 0, SemVer will reject the canaryIdentifier. In such cases, make sure we include enough of the sha to get a letter.
    @MichaelRyanWebber
    MichaelRyanWebber committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d511a2e View commit details
    Browse the repository at this point in the history

  2. add comment

    @MichaelRyanWebber
    MichaelRyanWebber committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    c214a53 View commit details
    Browse the repository at this point in the history