Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: NPM GH release publishing should set latest #2423

Closed
wants to merge 2 commits into from

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Jan 22, 2024

What Changed

Updated the NPM plugin to set nextRelease flag when calling git.publish.

Why

It looks like GH releases in the NPM plugin aren't using the nextRelease flag that was introduced in #2391

fixes: #2422

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@jackw jackw force-pushed the jackw/fix-npm-latest-release branch from 63fe781 to fce0e96 Compare January 24, 2024 09:05
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a6f0ae) 85.92% compared to head (fce0e96) 80.58%.

Files Patch % Lines
plugins/npm/src/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
- Coverage   85.92%   80.58%   -5.34%     
==========================================
  Files          69       69              
  Lines        5675     5675              
  Branches     1332     1274      -58     
==========================================
- Hits         4876     4573     -303     
- Misses        718      719       +1     
- Partials       81      383     +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jazmon
Copy link
Contributor

jazmon commented Feb 21, 2024

Seems like a duplicate of my fix #2414

@hipstersmoothie
Copy link
Collaborator

@jackw or @jazmon I think the logic in your PRs should be combined

@jazmon
Copy link
Contributor

jazmon commented Feb 22, 2024

@hipstersmoothie I combined the contents from this PR to my PR if you could have a look 🙏 #2414

@jackw
Copy link
Contributor Author

jackw commented Feb 22, 2024

Let's close this as @jazmon has gone to the trouble of bringing the two together. Awesome work everybody! 🚀

@jackw jackw closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPM: Auto doesn't set latest GH release when publishing
3 participants