NPM: Fix lerna version erroring with unknown registry arg #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 85.92% 80.58% -5.34%
==========================================
Files 69 69
Lines 5675 5675
Branches 1332 1274 -58
==========================================
- Hits 4876 4573 -303
- Misses 718 719 +1
- Partials 81 383 +302 ☔ View full report in Codecov by Sentry. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Removed the
getRegistryArgs()calls toversioncommand when in dry run.Why
Lerna added a global flag for passing
--registryto any of its commands. This was then removed later on in v7.2.0+.Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor