Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only remove labels if they exist on the PR #2396

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

hborawski
Copy link
Collaborator

What Changed

Why

Maybe its just our enterprise github, but when updating to 11.x in one project, pr-check was failing with a 404, root cause being pr-body-labels trying to remove labels that arent applied to the PR, throwing up to the prCheck hook

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2396 (db0f6cc) into main (b351c58) will decrease coverage by 0.07%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2396      +/-   ##
==========================================
- Coverage   80.64%   80.58%   -0.07%     
==========================================
  Files          69       69              
  Lines        5673     5675       +2     
  Branches     1274     1274              
==========================================
- Hits         4575     4573       -2     
- Misses        718      719       +1     
- Partials      380      383       +3     
Files Changed Coverage Δ
plugins/pr-body-labels/src/index.ts 70.83% <100.00%> (+2.65%) ⬆️

... and 3 files with indirect coverage changes

@hipstersmoothie hipstersmoothie merged commit 3fb2bee into intuit:main Sep 10, 2023
6 of 9 checks passed
@github-actions github-actions bot added the patch Increment the patch version when merged label Sep 10, 2023
@github-actions
Copy link

🚀 PR was released in v11.0.4 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants