Updating all-contributors-cli dependency #2360
Conversation
|
@jdalrymple doesn't look like the lock file is fully updated |
|
Oh darn! Will do. Which version of yarn? I want to make sure when i do the update it doesnt refresh all of the yarn files |
|
we're on v1 |
Codecov Report
@@ Coverage Diff @@
## main #2360 +/- ##
==========================================
+ Coverage 80.55% 82.81% +2.25%
==========================================
Files 69 69
Lines 5668 5614 -54
Branches 1330 1317 -13
==========================================
+ Hits 4566 4649 +83
+ Misses 719 711 -8
+ Partials 383 254 -129
|
|
Looking at the failed tasks, should i be addressing the typing errors in other files? |
|
Looks like there is only lint failures now. Once that's good I can merge |
Yes, but in a file that wasnt changed...?
|
|
Looking into it! Might be related to yarn |
|
Scratch that, i have no idea. When i run the lint script locally it also receive many more errors that have absolutely nothing to do with the code. For example: /home/flynn/Projects/personal/auto/packages/cli/src/run.ts |
|
Maybe the update of the yarn lock is using a more recent version of the eslint lib since the pkg.json doesnt lock them to a specific version? |
|
I'll pull this today and figure it out! |
|
Adding the type prefix seemed to fix most of this issues, but its quite a bit of changes: https://stackoverflow.com/a/71375585/1812936 |
|
Using this lib: https://github.com/import-js/eslint-import-resolver-typescript, might help, though my tests with it didnt solve the issue |
What Changed
Updated the all-contributors-cli dependency
Why
To support new configuration within the cli
Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor