Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old references in maven instructions #2226

Merged
merged 1 commit into from Jul 11, 2022
Merged

Remove old references in maven instructions #2226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions plugins/maven/README.md
View file
Open in desktop
Expand Up @@ -107,14 +107,16 @@ You will need all the following configuration blocks for all parts of `auto` to
```xml
<scm>
<connection
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/Fuego-Tools/java-test-project.git</connection>
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/${owner}/${repo}.git</connection>
<developerConnection
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/Fuego-Tools/java-test-project.git</developerConnection>
<url>https://github.com/Fuego-Tools/java-test-project</url>
>scm:git:https://${env.GH_USER}:${env.GH_TOKEN}@github.com/${owner}/${repo}.git</developerConnection>
<url>https://github.com/${owner}/${repo}</url>
<tag>HEAD</tag>
</scm>
```

> :warning: Either replace `${owner}/${repo}` with the corresponding GitHub owner and repository for your project or ensure those are configured as properties within the `pom.xml`

3. Versions Maven Plugin **RECOMMENDED** (Optional)

```xml
Expand Down
8 changes: 4 additions & 4 deletions plugins/maven/__tests__/maven.test.ts
View file
Open in desktop
Expand Up @@ -147,8 +147,8 @@ describe("maven", () => {
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<scm>
<connection>scm:git:https://github.com/Fuego-Tools/java-test-project.git</connection>
<url>https://github.com/Fuego-Tools/java-test-project</url>
<connection>scm:git:https://github.com/intuit/auto.git</connection>
<url>https://github.com/intuit/auto</url>
<tag>HEAD</tag>
</scm>
</project>
Expand All @@ -158,8 +158,8 @@ describe("maven", () => {

expect(await hooks.getRepository.promise()).toStrictEqual(
expect.objectContaining({
owner: "Fuego-Tools",
repo: "java-test-project",
owner: "intuit",
repo: "auto",
})
);
});
Expand Down