Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding auto Fastlane plugin #2196

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Adding auto Fastlane plugin #2196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7a79421
Adding auto Fastlane plugin
yogeshkhandelwal Apr 29, 2022
5f6dd6f
updating version function
yogeshkhandelwal May 3, 2022
1691b2c
Updating function
yogeshkhandelwal May 3, 2022
9f0d6f3
Updating function
yogeshkhandelwal May 3, 2022
889dc69
removing updatePlist as it will be automatic
yogeshkhandelwal May 3, 2022
307c628
Added releaseType support
yogeshkhandelwal May 3, 2022
8e61350
Addding publish
yogeshkhandelwal May 3, 2022
0c8444d
moving fastlane to required
yogeshkhandelwal May 3, 2022
4eeecea
Disabling test
yogeshkhandelwal May 5, 2022
41a4382
Merge branch 'intuit:main' into main
ykhandelwal913 Jul 15, 2022
1401b8c
adding logging statement
yogeshkhandelwal Jul 15, 2022
510dcf4
test
yogeshkhandelwal Jul 15, 2022
43949a1
fixing build
yogeshkhandelwal Jul 15, 2022
d1ed309
Merge branch 'intuit:main' into main
ykhandelwal913 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
}
},
/** wait after abuse */
onAbuseLimit: (retryAfter: number, opts: ThrottleOpts) => {
onSecondaryRateLimit: (retryAfter: number, opts: ThrottleOpts) => {
this.logger.log.error(
`Went over abuse rate limit ${opts.method} ${
opts.url
Expand Down Expand Up @@ -852,7 +852,7 @@
}

/** Create a release for the GitHub project */
async publish(

Check warning on line 855 in packages/core/src/git.ts

View workflow job for this annotation

GitHub Actions / lint 

Async method 'publish' has too many parameters (5). Maximum allowed is 4
releaseNotes: string,
tag: string,
prerelease = false,
Expand Down
5 changes: 4 additions & 1 deletion packages/core/src/semver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,14 @@ export function calculateSemVerBump(
});

const lastMergedCommitLabels = prLabels[0] || [];
console.log("Last Merged Commit Labels: ", lastMergedCommitLabels)
const releaseLabels = labelMap.get("release") || [];
console.log("Release Labels: ", releaseLabels)
const skipRelease = onlyPublishWithReleaseLabel
? !lastMergedCommitLabels.some((label) => releaseLabels.includes(label))
: lastMergedCommitLabels.some((label) => skipReleaseLabels.includes(label));

console.log("skipRelease Value: ", skipRelease)

if (skipRelease) {
return SEMVER.noVersion;
}
Expand Down