Skip to content

don't prefix tags in lerna independent mode #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jul 31, 2020

What Changed

see title

Why

closes #1425

Todo:

  • Add tests
📦 Published PR as canary version: under canary scope @auto-canary@9.49.2-canary.1427.17789.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@9.49.2-canary.1427.17789.0
npm install @auto-canary/auto@9.49.2-canary.1427.17789.0
npm install @auto-canary/core@9.49.2-canary.1427.17789.0
npm install @auto-canary/all-contributors@9.49.2-canary.1427.17789.0
npm install @auto-canary/brew@9.49.2-canary.1427.17789.0
npm install @auto-canary/chrome@9.49.2-canary.1427.17789.0
npm install @auto-canary/cocoapods@9.49.2-canary.1427.17789.0
npm install @auto-canary/conventional-commits@9.49.2-canary.1427.17789.0
npm install @auto-canary/crates@9.49.2-canary.1427.17789.0
npm install @auto-canary/exec@9.49.2-canary.1427.17789.0
npm install @auto-canary/first-time-contributor@9.49.2-canary.1427.17789.0
npm install @auto-canary/gem@9.49.2-canary.1427.17789.0
npm install @auto-canary/gh-pages@9.49.2-canary.1427.17789.0
npm install @auto-canary/git-tag@9.49.2-canary.1427.17789.0
npm install @auto-canary/gradle@9.49.2-canary.1427.17789.0
npm install @auto-canary/jira@9.49.2-canary.1427.17789.0
npm install @auto-canary/maven@9.49.2-canary.1427.17789.0
npm install @auto-canary/npm@9.49.2-canary.1427.17789.0
npm install @auto-canary/omit-commits@9.49.2-canary.1427.17789.0
npm install @auto-canary/omit-release-notes@9.49.2-canary.1427.17789.0
npm install @auto-canary/released@9.49.2-canary.1427.17789.0
npm install @auto-canary/s3@9.49.2-canary.1427.17789.0
npm install @auto-canary/slack@9.49.2-canary.1427.17789.0
npm install @auto-canary/twitter@9.49.2-canary.1427.17789.0
npm install @auto-canary/upload-assets@9.49.2-canary.1427.17789.0
# or 
yarn add @auto-canary/bot-list@9.49.2-canary.1427.17789.0
yarn add @auto-canary/auto@9.49.2-canary.1427.17789.0
yarn add @auto-canary/core@9.49.2-canary.1427.17789.0
yarn add @auto-canary/all-contributors@9.49.2-canary.1427.17789.0
yarn add @auto-canary/brew@9.49.2-canary.1427.17789.0
yarn add @auto-canary/chrome@9.49.2-canary.1427.17789.0
yarn add @auto-canary/cocoapods@9.49.2-canary.1427.17789.0
yarn add @auto-canary/conventional-commits@9.49.2-canary.1427.17789.0
yarn add @auto-canary/crates@9.49.2-canary.1427.17789.0
yarn add @auto-canary/exec@9.49.2-canary.1427.17789.0
yarn add @auto-canary/first-time-contributor@9.49.2-canary.1427.17789.0
yarn add @auto-canary/gem@9.49.2-canary.1427.17789.0
yarn add @auto-canary/gh-pages@9.49.2-canary.1427.17789.0
yarn add @auto-canary/git-tag@9.49.2-canary.1427.17789.0
yarn add @auto-canary/gradle@9.49.2-canary.1427.17789.0
yarn add @auto-canary/jira@9.49.2-canary.1427.17789.0
yarn add @auto-canary/maven@9.49.2-canary.1427.17789.0
yarn add @auto-canary/npm@9.49.2-canary.1427.17789.0
yarn add @auto-canary/omit-commits@9.49.2-canary.1427.17789.0
yarn add @auto-canary/omit-release-notes@9.49.2-canary.1427.17789.0
yarn add @auto-canary/released@9.49.2-canary.1427.17789.0
yarn add @auto-canary/s3@9.49.2-canary.1427.17789.0
yarn add @auto-canary/slack@9.49.2-canary.1427.17789.0
yarn add @auto-canary/twitter@9.49.2-canary.1427.17789.0
yarn add @auto-canary/upload-assets@9.49.2-canary.1427.17789.0

Sorry, something went wrong.

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Jul 31, 2020
@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #1427 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   81.15%   81.16%           
=======================================
  Files          58       58           
  Lines        4261     4263    +2     
  Branches      936      938    +2     
=======================================
+ Hits         3458     3460    +2     
  Misses        563      563           
  Partials      240      240           
Impacted Files Coverage Δ
plugins/npm/src/index.ts 75.47% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89481d6...cbf088b. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit d3ff8dc into master Jul 31, 2020
@hipstersmoothie hipstersmoothie deleted the independent-prereleases branch July 31, 2020 17:39
@adierkens
Copy link
Collaborator

🚀 PR was released in v9.49.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Releases/Tags/Versions published have inconsistent naming
2 participants