Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SRE-30568] Tank V2 API Module Refactor #324

Merged
merged 8 commits into from
May 17, 2024
Merged

[SRE-30568] Tank V2 API Module Refactor #324

merged 8 commits into from
May 17, 2024

Conversation

Zakaria-Kofiro
Copy link
Collaborator

@Zakaria-Kofiro Zakaria-Kofiro commented May 1, 2024 •
edited

[SRE-30568] Tank V2 API Module Refactor

  1. Divide out the rest-mvc module into client and impl submodules
  2. Move the client module off of spring to httpclient
  3. Move Tank V2 API data model files to common module, the api module

Please make sure these check boxes are checked before submitting

  • ** Squashed Commits **
  • ** All Tests Passed ** - mvn clean test -P default

** PR review process **

  • Requires one +1 from a reviewer
  • Repository owners will merge your PR once it is approved.

@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review May 1, 2024 20:54
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as draft May 2, 2024 01:54
@Zakaria-Kofiro Zakaria-Kofiro marked this pull request as ready for review May 13, 2024 21:58
@Zakaria-Kofiro Zakaria-Kofiro merged commit 5a1498d into master May 17, 2024
@Zakaria-Kofiro Zakaria-Kofiro deleted the zkofiro/SRE-30568 branch May 17, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-mcgoldrick kevin-mcgoldrick kevin-mcgoldrick approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zakaria-Kofiro @kevin-mcgoldrick