Added if/else block for correct i18n extraction #9196
Merged
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
approved these changes
May 20, 2024
There was a problem hiding this comment.
Lgtm, thanks @merwhite11 ! Would you mind rebasing/regenerating the messages.pot file to fix the conflict?
cdrini
added
the
Needs: Submitter Input
merwhite11
force-pushed
the
delete-unused-variable
branch
from
fc259c3
to
01cf899
Compare
github-actions
bot
removed
the
Needs: Submitter Input
merwhite11
force-pushed
the
delete-unused-variable
branch
from
01049ab
to
71f50da
Compare
|
@cdrini alright, rebased and resolved conflict by manually accepting all incoming changes from most updated pot file in master. Then I ran the extraction command so that the extraction of this new change will be added on top of the up-to-date pot file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Addendum to:
#8981
Eliminates the need for a hard-coded-in-English variable here: #8981 (comment)
Technical
Added an if/else block ...repeats syntax, but extracts correctly in .pot
Testing
Ran
docker compose run --rm -uroot home ./scripts/i18n-messages extractto ensure message extracted correctly.Screenshot
Stakeholders
@cdrini