GRAM: parse of generic parameters for assoc types / type aliases and assoc type bindings #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernyavsky
force-pushed
the
fix-parsing-gat
branch
from
a0031dd
to
954229d
Compare
vlad20012
approved these changes
Feb 21, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 21, 2022
7816: IDE: convert JSON object to Rust struct after paste r=dima74 a=Kobzol This PR adds a copy paste processor that tries to convert pasted JSON-like text to a Rust struct (according to the `serde` data model). Currently it does not actually implement any `serde` things on the struct to keep this PR simpler (but it's easy to add `Serialize/Deserialize` derive to the struct using existing intentions and completion). It currently works like this:  Improvements (possibly for follow-up PRs): - [ ] Add `#[derive(Serialize, Deserialize)]`, possibly with auto import of these traits. - [ ] Add `serde` with `derive` feature (or `serde_derive` in edition 2015) to `Cargo.toml` if it's not already included (#7405) - [ ] Parametrize the behaviour in settings (allow to turn it off). Not sure if this is needed `@Undin?` Fixes: #7783 changelog: You can now paste JSON objects into Rust files and convert them to a Rust struct. 8542: GRAM: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings r=vlad20012 a=mchernyavsky Relates to #6633. changelog: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings 8571: ANN: Fix incorrectly providing `Add unsafe to function` in the main function r=Undin a=Stzx changelog: Fixed: #8530 8586: UI: fix wrong indents in new project panel with new project wizard r=ozkriff a=Undin It's a temporary workaround. The proper solution should be done as part of #8585 | Before | After | | - | - | | <img width="889" alt="Screen Shot 2022-02-21 at 15 58 18" src="https://user-images.githubusercontent.com/2539310/154959839-c43eb073-2a8d-46d0-b206-ad9d62cde61b.png"> | <img width="890" alt="Screen Shot 2022-02-21 at 15 55 52" src="https://user-images.githubusercontent.com/2539310/154959488-26d3712a-5ca6-4451-b6ae-cd8edfa08d41.png"> | Fixes #8508 changelog: Fix wrong indents in UI during creation of a new Rust project in IDEA Co-authored-by: Jakub Beránek <berykubik@gmail.com> Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com> Co-authored-by: Stzx <silence.m@hotmail.com> Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Feb 21, 2022
7816: IDE: convert JSON object to Rust struct after paste r=dima74 a=Kobzol This PR adds a copy paste processor that tries to convert pasted JSON-like text to a Rust struct (according to the `serde` data model). Currently it does not actually implement any `serde` things on the struct to keep this PR simpler (but it's easy to add `Serialize/Deserialize` derive to the struct using existing intentions and completion). It currently works like this:  Improvements (possibly for follow-up PRs): - [ ] Add `#[derive(Serialize, Deserialize)]`, possibly with auto import of these traits. - [ ] Add `serde` with `derive` feature (or `serde_derive` in edition 2015) to `Cargo.toml` if it's not already included (#7405) - [ ] Parametrize the behaviour in settings (allow to turn it off). Not sure if this is needed `@Undin?` Fixes: #7783 changelog: You can now paste JSON objects into Rust files and convert them to a Rust struct. 8542: GRAM: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings r=vlad20012 a=mchernyavsky Relates to #6633. changelog: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings Co-authored-by: Jakub Beránek <berykubik@gmail.com> Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Feb 22, 2022
8542: GRAM: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings r=vlad20012 a=mchernyavsky Relates to #6633. changelog: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 22, 2022
8542: GRAM: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings r=vlad20012 a=mchernyavsky Relates to #6633. changelog: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed: |
mchernyavsky
force-pushed
the
fix-parsing-gat
branch
from
954229d
to
b08f2b5
Compare
vlad20012
force-pushed
the
fix-parsing-gat
branch
from
b08f2b5
to
792826c
Compare
mchernyavsky
force-pushed
the
fix-parsing-gat
branch
from
952e9a1
to
26b2fda
Compare
vlad20012
approved these changes
Apr 29, 2022
mchernyavsky
force-pushed
the
fix-parsing-gat
branch
2 times, most recently
from
57718d1
to
959f2fb
Compare
…iases and assoc type bindings Co-authored-by: vlad20012 <beskvlad@gmail.com>
mchernyavsky
force-pushed
the
fix-parsing-gat
branch
from
959f2fb
to
fe082f1
Compare
bors bot
added a commit
that referenced
this pull request
Apr 29, 2022
8542: GRAM: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings r=vlad20012 a=mchernyavsky Relates to #6633. changelog: Fix parsing of generic parameters for assoc types / type aliases and assoc type bindings Co-authored-by: mhernyavsky <chernyavsky.mikhail@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Undin
changed the title
Undin
reviewed
Apr 30, 2022
bors bot
added a commit
that referenced
this pull request
Dec 9, 2022
8544: TY: Support type inference for GATs r=vlad20012 a=mchernyavsky Relates to #6633. Depends on #8542. changelog: Provide initial type inference support for [GATs](https://blog.rust-lang.org/2022/10/28/gats-stabilization.html) Co-authored-by: Mikhail Chernyavsky <mikhail.chernyavsky@jetbrains.com> Co-authored-by: vlad20012 <beskvlad@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6633.
changelog: Parse of generic parameters for assoc types / type aliases and assoc type bindings