Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add rhythmbox #3497

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

donheshanthaka
Copy link
Contributor

Implement rhythmbox checker

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Black has a complaint about test/test_data/rhythmbox.py that you'll need to resolve here.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks ready to go. I'm going to let the windows tests complete before merging, but I'll mark it as approved now so you get the hacktoberfest credit in case you're participating.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Darn, this one is also having windows errors:

 =========================== short test summary info ===========================
FAILED test/test_condensed_downloads.py::test_condensed_downloads - AssertionError: Condensed downloads are not commited
assert False
 +  where False = all(<generator object test_condensed_downloads.<locals>.<genexpr> at 0x0000024A809BE880>)
FAILED test/test_scanner.py::TestScanner::test_version_mapping[rhythmbox-3.4.6-version_strings417] - AssertionError: assert 'rhythmbox' in set()
FAILED test/test_scanner.py::TestScanner::test_version_in_package[http://ftp.fr.debian.org/debian/pool/main/r/rhythmbox/-rhythmbox_3.4.7-1_i386.deb-rhythmbox-3.4.7-other_products851] - AssertionError: rhythmbox not found in rhythmbox_3.4.7-1_i386.deb.
          The checker signature or url may be incorrect.
assert 'rhythmbox' in set()

I'm not sure what's going on here at a glance, but I will go mark this (and the other one) as approved for hacktoberfest in case you need the credit. I don't want to penalize you for trying something harder than a one-line commit if you were hoping to get credit!

@terriko terriko added HACKTOBERFEST-ACCEPTED awaiting response Need more information from submitter labels Nov 1, 2023
@donheshanthaka
Copy link
Contributor Author

@terriko Thanks a lot, i'll really appreciate you adding the tags, this is the only project that i got the chance to contribute this year. i'm a bit confused on whats causing the windows only fails, but i'm checking on them and will try my best to fix them soon. If you were to find anything related to the cause kindly let me know :)

@donheshanthaka
Copy link
Contributor Author

Hi, @terriko just wanted to let you know that I don't have access to my computer till Monday, but I will make the necessary changes once I do. giving you an update since you helped me by adding the tags and I would not abandon this and other the two PRs. :)

@terriko
Copy link
Contributor

terriko commented Nov 2, 2023

@donheshanthaka Have a good weekend! I'm actually out dealing with appointments on Monday, so I probably won't come back to poke at these until after you're back, then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response Need more information from submitter HACKTOBERFEST-ACCEPTED
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants