Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to apk install of docker-compose #38

Merged
merged 4 commits into from Sep 21, 2022
Merged

Change to apk install of docker-compose #38

merged 4 commits into from Sep 21, 2022

Conversation

dvintel
Copy link
Contributor

@dvintel dvintel commented Jul 29, 2022

No description provided.

@brod-intel
Copy link
Contributor

What is the reason, for this change?

@dvintel
Copy link
Contributor Author

dvintel commented Aug 8, 2022

Core started failing saying there were outdated versions of python. Update to latest version of docker-compose fixes it.
However, the new version of docker-compose changes the way names are generated slightly which requires the other PR as well.

On a related note, if we run the docker ps command, we can grep for the image name rather than relying on the name generated by docker-compose. The ps command returns both, and the image name seems like a safer thing to look for in case they decide to change the way they generate names for instances.

@dvintel
Copy link
Contributor Author

dvintel commented Aug 9, 2022

docker-compose has released another version, 2.9 since 2.8 had a breaking change.
From their docs:
v2.8.0
⚠️ Warning notice ⚠️
This release introduced a breaking change via compose-go v1.3.0 and this compose-spec/compose-go#294.
Docker Compose will recreate new resources (networks, volumes, secrets, configs...) with new names, using a - instead a _ and try to connect/use to this new created resources instead of your existing ones!
Please use Compose v2.9.0 instead

we should update to 2.9.0 instead of 2.8

There was a breaking change in v2.8.0 which has been fixed in v2.9.0.
Using - instead of _ for for names
@dvintel
Copy link
Contributor Author

dvintel commented Sep 15, 2022

After further exploration, we can use apk to install docker-compose rather than pulling it from github repo releases. This has the added benefit of making sure we are using the alpine version of docker-compose

@dvintel dvintel changed the title Update to latest version of docker-compose Change to apk install of docker-compose Sep 15, 2022
@dvintel dvintel merged commit 4717379 into master Sep 21, 2022
@dvintel dvintel deleted the dvintel-patch-2 branch December 15, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants