Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to set the action and reusable workflow access level #1441

Closed
wants to merge 2 commits into from

Conversation

wwsean08
Copy link
Contributor

Resolves #1418


Behavior

Before the change?

  • There was no way to specify the action access setting to allow other repositories to use your private/internal repositories actions and reusable workflows in their own.

After the change?

  • This allows you to set whether or not another repository in within your user, organization, or enterprise can use this repositories actions and reusable workflows.

Other information

  • Tested via unit tests for both user and organization, see screenshots below
  • I did find that allowed_actions needed to be set when using this, so there may need to be some additional logic to allow this setting alone. But if that is considered acceptable I will leave it.

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Feature/model/API additions: Type: Feature

Screen Shot 2022-12-17 at 2 17 48 PM
Screen Shot 2022-12-17 at 2 44 35 PM

@wwsean08 wwsean08 marked this pull request as draft December 18, 2022 18:35
@wwsean08
Copy link
Contributor Author

After trying to dig in and figure out how to handle both of the scenarios of managing actions within the repo and managing access to the repo's actions and reusable workflows I have come to the conclusion there isn't a good way to do this within one resource. I'll open a new PR with a new resource which should make life much simpler.

@wwsean08 wwsean08 closed this Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow Defining Actions Access Settings on a Repository
1 participant