Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetRoleName() instead of permission mapping not backward compatible. #1222

Closed
schans opened this issue Jul 18, 2022 · 2 comments · Fixed by #1224 or #1369
Closed

Use GetRoleName() instead of permission mapping not backward compatible. #1222

schans opened this issue Jul 18, 2022 · 2 comments · Fixed by #1224 or #1369

Comments

@schans
Copy link

schans commented Jul 18, 2022

Hi there,

Terraform Version

4.27.0

Affected Resource(s)

  • resource_github_team_repository

Expected Behavior

Things keep working as in <4.27.0

Actual Behavior

Non-custom roles are broken as the naming is different. read vs pull, write vs push etc.
For a lot more info see: #1192

Steps to Reproduce

Upgrade from <4.27.0 to 4.27.0 and run tf apply

Important Factoids

Seems a bit of a mess due to historic reasons as Github? https://github.community/t/is-the-api-insane-with-respect-to-collaborators-or-am-i-confused/253696

References

Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example:

@Luis-3M
Copy link

Luis-3M commented Aug 4, 2022

Many thanks @kfcampbell.
Given that we've successfully reverted PR #1192 , should we close this issue and open a new one regarding the original broken behaviour when using custom roles?

@kfcampbell
Copy link
Member

That sounds good to me! I've chosen to reopen #1183.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants