-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import initial CI configuration #7
base: main
Are you sure you want to change the base?
Conversation
The jobs are running on my fork, so you can see them pass here: https://github.com/russellb/instructlab-training/actions This is split up into separate commits to make it easier to review. The bulk import of config that doesn't touch code is the first commit. Code changes are split apart so you can more easily see changes from the formatting tool vs "real" code changes, along with their explanations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Import jobs to run - linting of github workflows (actionlint) - python formatting and linting - spell checking - markdown linting This also includes requirements*.txt files. Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Russell Bryant <rbryant@redhat.com>
For example: ``` main_ds.py:50:16: W0621: Redefining name 'args' from outer scope (line 280) (redefined-outer-name) main_ds.py:100:10: W0621: Redefining name 'args' from outer scope (line 280) (redefined-outer-name) main_ds.py:188:9: W0621: Redefining name 'args' from outer scope (line 280) (redefined-outer-name) tokenizer_utils.py:38:24: W0621: Redefining name 'SPECIAL_TOKENS' from outer scope (line 22) (redefined-outer-name) tokenizer_utils.py:38:55: W0621: Redefining name 'CHAT_TEMPLATE' from outer scope (line 24) (redefined-outer-name) data_process.py:173:9: W0621: Redefining name 'args' from outer scope (line 271) (redefined-outer-name) ``` Signed-off-by: Russell Bryant <rbryant@redhat.com>
By prefixing the unused arguments with an underscore, pylint understands this as a hint that we intentionally ignore the argument. Signed-off-by: Russell Bryant <rbryant@redhat.com>
Drop a couple of f-strings without any interpolation, set an encoding type on `open()`, and update the pylint configuration to ignore all remaining warnings for now. Signed-off-by: Russell Bryant <russell.bryant@gmail.com>
This code is not backend-specific, so drop it from the readme title. While we're at it, capitalize DeepSpeed as the upstream project does it. While we're at it, add badges to README. Signed-off-by: Russell Bryant <rbryant@redhat.com>
closed by accident |
@russellb think we should revisit this for the librarification? |
imo yes |
tox -e ruff
formatting changescommit e489e17
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 07:48:01 2024 -0400
commit 76d83f0
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 07:48:22 2024 -0400
commit 29fe072
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 07:55:07 2024 -0400
commit e88162f
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 08:02:24 2024 -0400
commit b6adf5d
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 08:05:24 2024 -0400
commit 45003e1
Author: Russell Bryant rbryant@redhat.com
Date: Wed May 1 08:12:21 2024 -0400
commit 851d73a
Author: Russell Bryant rbryant@redhat.com
Date: Mon Apr 29 10:08:19 2024 -0400