Support for running image-based gadgets test in k8s #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
My idea was more to implement a new "kubernetes container runtime". i.e. something that runs containers using kubernetes. I hacked a bit and got something working on fa5f2d1, please check the commit message with more details.
What do you think about using it?
pawarpranav83
force-pushed
the
testing-fw
branch
3 times, most recently
from
e2ec249
to
052e435
Compare
pawarpranav83
force-pushed
the
testing-fw
branch
3 times, most recently
from
44191ae
to
f3881ac
Compare
pawarpranav83
requested review from
blanquicet,
mqasimsarfraz and
alban
as code owners
pawarpranav83
force-pushed
the
testing-fw
branch
2 times, most recently
from
02bb6a1
to
a027fd6
Compare
mauriciovasquezbernal
approved these changes
May 31, 2024
|
Should we add a job for running these tests in a minikube cluster, we just have the |
|
That would be great if you are able to make it. Perhaps we can reuse the same job with a matrix strategy. |
Signed-off-by: pawarpranav83 <pawar.pranav83@gmail.com>
Signed-off-by: pawarpranav83 <pawar.pranav83@gmail.com>
eiffel-fl
reviewed
Jun 3, 2024
Signed-off-by: pawarpranav83 <pawar.pranav83@gmail.com>
…for testing with k8s Signed-off-by: pawarpranav83 <pawar.pranav83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for running image-based gadgets test in k8s cluster with kubectl-gadget.
Previously we were running the test with ig alongside local containers, this PR adds support for running these tests with kubectl-gadget in the k8s cluster (minikube).
We try to have a single test, which applies different options for the factory runner as well as expected entry based on whether it's
igorkubectl-gadget.Issue #2046
How to use
Set
IG_PATH=ig(for testing with local containers using ig) orIG_PATH=kubectl-gadgetandIG_RUNTIME=kubernetes(for testing with containers running in minikube cluster, need to runminikube-deploybefore).Note: You can set this to the actual path of those applications as well, for example,
./igor./kubectl-gadget, should contain the keywordkubectl-gadgetforCurrentTestComponentto be set asKubectlGadgetTestComponent.Test Command:
make -C ./gadgets test-k8s