Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gadgets: Add README.md for image-based gadgets #2726

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mqasimsarfraz
Copy link
Member

@mqasimsarfraz mqasimsarfraz commented Apr 17, 2024

Add README.md for image-based gadgets. This should be used by artifacthub to show the documentation for individual gadgets as well!

Related #2727

This PR only adds documentation for following gadgets:

  • snapshot_process
  • snapshot_socket
  • trace_exec
  • trace_open

@mqasimsarfraz
Copy link
Member Author

I am putting this on hold till #2736 is fixed

Copy link
Member

@alban alban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this documentation!

gadgets/snapshot_process/README.md Outdated Show resolved Hide resolved
Gather information about running processes.
---

> ⚠️ This feature is experimental and could change without prior notification. Check the installation guide to enable [experimental features](../../docs/getting-started/install-linux.md#experimental-features).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this doc aims to be published on artifacthub and all gadgets published on artifacthub are necessarily image-based gadgets, I suggest to remove that line: this image-based gadget is not more experimental than other image-based gadgets.

What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think?

The main reason to include it here is to ensure the user doesn't get any surprises with kubectl gadget run snapshot_process like they need to deploy Inspektor Gadget with experimental to be able to follow steps on this guide?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps we should rephrase it to say This feature requires Inspektor Gadget has been installed with experimental features enabled ?

Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants