Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration: Remove containerd workaround for TestTraceOomkill #1303

Merged
merged 1 commit into from
Jan 30, 2023
Merged

integration: Remove containerd workaround for TestTraceOomkill #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/inspektor-gadget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,13 +544,6 @@ jobs:
sudo add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu $(lsb_release -cs) test"
sudo apt-get update
sudo apt-get install docker-ce
# For containerd, swap limit isn't propogated to memory controller of pod cgroup with
# memory.memsw.limit_in_bytes set to a large value, resulting in OOM not triggered.
# Disable swap to make things simpler for us
- name: Disable swap for ${{ matrix.runtime }}
if: matrix.runtime == 'containerd'
run: |
sudo swapoff -a
- name: Run integration for container runtime ${{ matrix.runtime }}
run: |
set -o pipefail
Expand Down
2 changes: 1 addition & 1 deletion minikube.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MINIKUBE_VERSION ?= v1.28.0
MINIKUBE_VERSION ?= v1.29.0
KUBERNETES_VERSION ?= v1.24.6
MINIKUBE_DRIVER ?= docker

Expand Down