Pin ffi to 1.12.2 due to Windows crash #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-stocks
added
Type: Bug
|
See the verify pipeline build history for the failures this addresses: The bug manifests as InSpec quietly crashing on Windows for any command except |
Gemfile
Outdated
| @@ -9,7 +9,7 @@ gem "inspec", path: "." | |||
| # in it in order to package the executable. Hence the odd backwards dependency. | |||
| gem "inspec-bin", path: "./inspec-bin" | |||
|
|
|||
| gem "ffi", ">= 1.9.14" | |||
| gem "ffi", "1.12.2" # 1.13 does not work on Windows: https://github.com/ffi/ffi/issues/784 | |||
There was a problem hiding this comment.
Can we loosen this to [">= 1.9.14", "< 1.13"] to allow flexibility in resolving this when packaging?
There was a problem hiding this comment.
Good call, updated.
See ffi/ffi#784 Signed-off-by: James Stocks <jstocks@chef.io>
|
Thanks very much for this @james-stocks ! I just ran this code on a windows machine that was broken yesterday and now up and running 100%! 🎉 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ffi/ffi#784
Signed-off-by: James Stocks jstocks@chef.io