Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http resource: Support OPTIONS method #2742

Merged
merged 1 commit into from Feb 27, 2018
Merged

http resource: Support OPTIONS method #2742

merged 1 commit into from Feb 27, 2018

Conversation

cbeckr
Copy link
Contributor

@cbeckr cbeckr commented Feb 25, 2018

This patchset adds support for the HTTP OPTIONS method by using run_request since Faraday does not support an options method.
See lostisland/faraday#305 for background.

@cbeckr
http resource: Support OPTIONS method
1550721 
Signed-off-by: Christian Becker <c.becker@mediaevent.services>
@cbeckr cbeckr requested a review from a team as a code owner February 25, 2018 15:57
jquick
jquick approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @cbeckr. Pulled this down and looks good to me!

clintoncwolfe
clintoncwolfe approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - code looks good, and very good tests!

adamleff
adamleff approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! Thanks for your first contribution to InSpec, @cbeckr :)

@jquick jquick merged commit b768776 into inspec:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

@jquick jquick jquick approved these changes

@adamleff adamleff adamleff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cbeckr @clintoncwolfe @jquick @adamleff