Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff stylechecking #159

Merged
merged 4 commits into from Jan 20, 2023
Merged

ruff stylechecking #159

merged 4 commits into from Jan 20, 2023

Conversation

gsarti
Copy link
Member

@gsarti gsarti commented Jan 12, 2023

Description

This PR replaces isort, flake8, bandit, pylint and pyupgrade with the ruff library, both for regular quality checks and for pre-commit validation.

The main benefits for such replacement are:

  • A centralized, dependency-free tool for most style checks.
  • Blazing fast, avoid waiting on every pre-commit (was ~4min because of flake8, down to a fraction of a second now).
  • Close compatibility to previous stylechecking, with the exception of some isort formatting that is ok to drop.

The currently committed settings are already good, but tests are failing because the codebase wasn't update according to the new stylechecker. Waiting for #148 and #157 to get merged in main to apply all style updates in a single pass and merge.

@gsarti gsarti added enhancement New feature or request dev qol Quality of life improvements for library developers labels Jan 12, 2023
@gsarti gsarti merged commit bbac850 into main Jan 20, 2023
@gsarti gsarti deleted the ruff-stylechecker branch January 20, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev qol Quality of life improvements for library developers enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant