Use require() for dynamic imports, use new name of solid-auth-fetcher #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now published under the @inrupt scope.
Vinnl
force-pushed
the
fix/dynamic-imports
branch
3 times, most recently
from
bd6e643
to
60c5e0a
Compare
NSeydoux
approved these changes
May 11, 2020
Webpack issues a warning when trying to import() a module that is not present, whereas it does not do so — or at least, not in a way that blocks Next.js from building the app — with require(). Since we're requiring a bundler anyway (since we're using npm package names rather than import paths), we're not any worse off using a non-standard module system for these. For more info, see: webpack/webpack#7713
Vinnl
force-pushed
the
fix/dynamic-imports
branch
from
60c5e0a
to
e80382d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack issues a warning when trying to import() a module that is
not present, whereas it does not do so — or at least, not in a way
that blocks Next.js from building the app — with require(). Since
we're requiring a bundler anyway (since we're using npm package
names rather than import paths), we're not any worse off using a
non-standard module system for these.
For more info, see: webpack/webpack#7713
I still couldn't get solid-auth-fetcher to work, but this should at least make it work with solid-auth-client and native fetch in Next.js, which the Pod Manager will likely use.