Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated packages to latest version #41

Closed
wants to merge 8 commits into from

Conversation

Bullrich
Copy link
Contributor

@Bullrich Bullrich commented Dec 9, 2021

System changed

  • Dependency versions
  • Build

Description

Updated packages to latest version to support new features available in GitHub Actions, including GitHub enterprise edition (this PR brings that new functionality: actions/toolkit#794).

Some dependency types have changed and they have been updated to the new types.

The octokitHack.ts file is no longer needed as that bug has been fixed: actions/toolkit#228

The build directory has been recreated.

@Bullrich Bullrich changed the title Updated packages to latest version updated packages to latest version Dec 9, 2021
@Bullrich
Copy link
Contributor Author

Bullrich commented Dec 9, 2021

@bfercher or @rYuuk can you please assign a reviewer and look into this PR? This should provide some new functionalities as it updates the library itself.

@bfercher
Copy link

bfercher commented Dec 9, 2021

@Bullrich is alive 💯

@Bullrich Bullrich force-pushed the update-packages branch 2 times, most recently from 70c9a2d to d79c1ac Compare December 9, 2021 17:36
@Bullrich
Copy link
Contributor Author

Bullrich commented Dec 9, 2021

@Bullrich is alive 💯

I am alive and on fire 🔥 🔥 🔥

@Bullrich
Copy link
Contributor Author

@bfercher can you look into the ci error? circleci seems to not be working anymore. I added a javascript action to run the tests using GitHub actions instead.

@Bullrich Bullrich force-pushed the update-packages branch 2 times, most recently from 7303c5b to 641a5fc Compare December 17, 2021 15:22
@Bullrich
Copy link
Contributor Author

@bfercher I created the exact same PR to the same branch here: Bullrich#1

And Prace.js is working, it is reading the file (and failing as intended). Did you modify anything in the configuration of the repository? Should we ignore this and hard merge it?

@Bullrich
Copy link
Contributor Author

Closed as no one is looking at it. I decided to create my own implementation available in https://github.com/Bullrich/Prace.js

@Bullrich Bullrich closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants