Issue/3100 create v2 modules #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderr
commented
Nov 18, 2021
| @@ -5,5 +5,5 @@ | |||
| "author_email": "code@inmanta.com", | |||
| "license": "ASL 2.0", | |||
| "copyright": "{% now 'local', '%Y' %} Inmanta", | |||
| "minimal_compiler_version": "2019.3" | |||
| "_extensions": ["cookiecutter.extensions.SlugifyExtension"] | |||
There was a problem hiding this comment.
See https://cookiecutter.readthedocs.io/en/latest/advanced/template_extensions.html#slugify-extension. Used to convert _ to - where appropriate (Python package name mostly). We could also define a custom extension if anyone prefers.
arnaudsjs
approved these changes
Nov 19, 2021
wouterdb
approved these changes
Nov 19, 2021
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arnaudsjs the bulk of this is from the changes you made but I've made some minor changes/additions to reflect the latest state of modules v2.
I won't merge this into master. Instead I'll move it to a branch named
v2so it can be used withcookiecutter --checkout v2 <url>.part of inmanta/inmanta-core#3100