Skip to content

Commit

Permalink
Updated Makefile to disable mypy error limit (PR #3862)
Browse files Browse the repository at this point in the history
# Description

Fixes python/mypy#10956

Thanks @bartv

# Self Check:

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

# Reviewer Checklist:

- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Code is clear and sufficiently documented
- [ ] Correct, in line with design
  • Loading branch information
sanderr committed Feb 22, 2022
1 parent b7b4689 commit 6d7aeb1
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -26,7 +26,7 @@ pep8:
flake8 src tests tests_common

.PHONY: mypy mypy-diff mypy-save
RUN_MYPY=MYPYPATH=stubs:src python -m mypy --html-report mypy -p inmanta
RUN_MYPY=MYPYPATH=stubs:src python -m mypy --soft-error-limit=-1 --html-report mypy -p inmanta

mypy:
$(RUN_MYPY)
Expand Down
6 changes: 6 additions & 0 deletions changelogs/unreleased/mypy-error-limit-fix.yml
@@ -0,0 +1,6 @@
description: Updated Makefile to disable mypy error limit
change-type: patch
destination-branches:
- iso4
- iso5
- master
2 changes: 1 addition & 1 deletion tox.ini
Expand Up @@ -55,5 +55,5 @@ commands_pre = mkdir -p coverage
whitelist_externals = */mkdir
setenv = MYPYPATH=stubs:src
commands =
python -m mypy --junit-xml mypy.xml --cobertura-xml-report coverage -p inmanta
python -m mypy --soft-error-limit=-1 --junit-xml mypy.xml --cobertura-xml-report coverage -p inmanta
ignore_outcome = true

0 comments on commit 6d7aeb1

Please sign in to comment.