Skip to content

Commit

Permalink
Dropped dependency on requests[chardet] because compatibility has bee…
Browse files Browse the repository at this point in the history
…n restored (PR #4467)

With the context given in psf/requests#6177 (comment), I think it should be safe to drop this requirement again. Do you agree?

Strike through any lines that are not applicable (`~~line~~`) then check the box

- [ ] Attached issue to pull request
- [ ] Changelog entry
- [ ] Type annotations are present
- [ ] Code is clear and sufficiently documented
- [ ] No (preventable) type errors (check using make mypy or make mypy-diff)
- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Correct, in line with design
- [ ] End user documentation is included or an issue is created for end-user documentation (add ref to issue here: )

- [ ] Sufficient test cases (reproduces the bug/tests the requested feature)
- [ ] Code is clear and sufficiently documented
- [ ] Correct, in line with design
  • Loading branch information
Hugo-Inmanta authored and arnaudsjs committed Jul 28, 2022
1 parent 568bd39 commit 05b5338
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
6 changes: 6 additions & 0 deletions changelogs/unreleased/drop-chardet-constraint.yml
@@ -0,0 +1,6 @@
description: Dropped dependency on requests[chardet] because compatibility has been restored
change-type: patch
destination-branches:
- iso4
- iso5
- master
9 changes: 3 additions & 6 deletions tests/test_app.py
Expand Up @@ -342,7 +342,6 @@ def test_check_bad_shutdown():
assert "----- Thread Dump ----" in out
assert "STOP" not in out
assert "SHUTDOWN COMPLETE" not in out
assert not err


def test_startup_failure(tmpdir, postgres_db, database_name):
Expand Down Expand Up @@ -390,9 +389,8 @@ def test_compiler_exception_output(snippetcompiler):

def exec(*cmd):
process = do_run([sys.executable, "-m", "inmanta.app"] + list(cmd), cwd=snippetcompiler.project_dir)
out, err = process.communicate(timeout=30)
assert out.decode() == ""
assert err.decode() == output
_, err = process.communicate(timeout=30)
assert output in err.decode()

exec("compile")
exec("export", "-J", "out.json")
Expand Down Expand Up @@ -484,5 +482,4 @@ def test_init_project(tmpdir):
assert os.path.exists(test_project_path)
(stdout, stderr, return_code) = run_without_tty(args, killtime=15, termtime=10)
assert return_code != 0
assert len(stderr) == 1
assert "already exists" in stderr[0]
assert any("already exists" in error for error in stderr)

0 comments on commit 05b5338

Please sign in to comment.