allows config for leeway of 'nbf' and 'exp' #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change lets clients decide how much leeway should apply to the 'exp' and 'nbf' claims coming from the JWTs on inbound requests. It's a pass-through to the jwt library's functionality. See golang-jwt/jwt@d489c99 for related changes there.
|
Nice! This looks like it would fix the issue in #33. |
bmorton
reviewed
Mar 21, 2022
|
We have this running in our production environment with no problems. |
|
Hey @PrasadG193 or @sahil-lakhwani, is there any chance one of you would have time to review this? |
|
Just wanted to drop a note that the underlying change in the jwt-go library supporting this was reverted recently due to backwards-compatibility issues. We had no problem compiling with this library but I understand if we want to hold on bring this change in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets clients decide how much leeway should apply to the
'exp' and 'nbf' claims coming from the JWTs on inbound requests. It's
a pass-through to the jwt library's functionality.
See golang-jwt/jwt@d489c99
for related changes there.