ci: Test with CometBFT v0.38.2 #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
force-pushed
the
thane/ci/test-with-cometbft
branch
from
200ef4d
to
feed771
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
=======================================
Coverage 61.00% 61.00%
=======================================
Files 18 18
Lines 2072 2072
=======================================
Hits 1264 1264
Misses 680 680
Partials 128 128 |
Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson
changed the title
thanethomson
commented
Nov 28, 2023
| @@ -10,19 +10,21 @@ RUN apk update && \ | |||
| apk upgrade && \ | |||
| apk --no-cache add curl jq file shadow | |||
|
|
|||
| RUN groupadd -g ${GID} tmgroup || true | |||
There was a problem hiding this comment.
Fixes a problem in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we'd be able to build/test/run this against multiple versions of Comet, but until such time that we have capacity and demand for that we should at least use the latest major release.