Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Prost v0.8+ upgrade #978

Closed
wants to merge 10 commits into from
Closed

Conversation

thanethomson
Copy link
Member

Closes #925

Right now I'm depending on the prost* crates at a specific commit after the attributes issue has been merged. This PR will be ready for review once Prost cuts a new release.

This PR helps to ensure compatibility before we upgrade.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson mentioned this pull request Sep 17, 2021
5 tasks
@xla
Copy link
Contributor

xla commented Sep 20, 2021

Are we aware of the expected timeline of the new prost release?

@thanethomson
Copy link
Member Author

Are we aware of the expected timeline of the new prost release?

Not yet unfortunately 😞

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson mentioned this pull request Sep 22, 2021
@thanethomson
Copy link
Member Author

Superseded by #1005

@thanethomson thanethomson deleted the thane/925-prost-upgrade branch October 6, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0073: Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic
2 participants