Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.21.0 #935

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Release v0.21.0 #935

merged 5 commits into from
Jul 21, 2021

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Jul 20, 2021

馃摉 CHANGELOG rendered

The audit check will continue to fail due to #925

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson requested a review from romac July 20, 2021 15:43
@thanethomson thanethomson marked this pull request as ready for review July 20, 2021 15:43
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

Codecov Report

Merging #935 (c00d0bc) into master (f46cf0f) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #935   +/-   ##
======================================
  Coverage    70.4%   70.4%           
======================================
  Files         203     203           
  Lines       16333   16333           
======================================
+ Hits        11511   11513    +2     
+ Misses       4822    4820    -2     
Impacted Files Coverage 螖
light-client/src/lib.rs 100.0% <酶> (酶)
proto/src/lib.rs 100.0% <酶> (酶)
tendermint/src/lib.rs 100.0% <酶> (酶)
tendermint/src/block/commit_sig.rs 77.2% <0.0%> (-2.3%) 猬囷笍
light-client/src/types.rs 30.9% <0.0%> (+0.8%) 猬嗭笍
testgen/src/vote.rs 84.6% <0.0%> (+0.8%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update f46cf0f...c00d0bc. Read the comment docs.

CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@romac romac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-approving already :)

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殎 馃崵 馃捊 馃拋

The change to Informal Systems as the author for some of the crates is sub-optimal I think.

@thanethomson
Copy link
Member Author

The change to Informal Systems as the author for some of the crates is sub-optimal I think.

How so? 馃檪 I'd imagine it'd just be easier to have a single point of contact for Informal Systems. All other authors' details are kept as-is.

@thanethomson thanethomson merged commit d8e18c6 into master Jul 21, 2021
@thanethomson thanethomson deleted the release/v0.21.0 branch July 21, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants