Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: latest changes in sov_bank #154

Merged
merged 24 commits into from May 21, 2024
Merged

fix: latest changes in sov_bank #154

merged 24 commits into from May 21, 2024

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Apr 30, 2024 •
edited

Closes: #156
Closes: #157

  • syncs with Sovereign-Labs/sovereign-sdk-wip@50a866c0dccf974c035cbaf3ca289b0e4a29fcc9
  • minor changes due to
    • Sovereign-Labs/sovereign-sdk-wip#572
    • Sovereign-Labs/sovereign-sdk-wip#584

Description

PR author checklist

  • Linked to GitHub issue.
  • Added tests.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

@rnbguy rnbguy changed the title avoid custom sov_modules_api::Context imp: avoid custom sov_modules_api::Context Apr 30, 2024
@rnbguy rnbguy force-pushed the rano/avoid-rollup-context branch from da0e7da to 8bfebad Compare May 6, 2024 20:45
@rnbguy rnbguy marked this pull request as ready for review May 7, 2024 13:28
@rnbguy rnbguy changed the title imp: avoid custom sov_modules_api::Context fix: latest changes in sov_bank May 7, 2024
@rnbguy rnbguy requested a review from soareschen May 7, 2024 14:05
@rnbguy rnbguy marked this pull request as draft May 13, 2024 12:36
@rnbguy rnbguy marked this pull request as ready for review May 21, 2024 09:29
@rnbguy rnbguy merged commit 5d63b5a into main May 21, 2024
11 checks passed
@rnbguy rnbguy deleted the rano/avoid-rollup-context branch May 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen Awaiting requested review from soareschen

Assignees
No one assigned
Labels
None yet
Projects
sovereign-ibc
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

infallible impl Payable conversion from byte arrays avoid custom Context in ibc-transfer module
1 participant
@rnbguy