Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch away from rouille to axum in telemetry and REST servers #3200

Merged
merged 10 commits into from
Apr 4, 2023

Conversation

romac
Copy link
Member

@romac romac commented Mar 27, 2023

Closes: #1658
Closes: #1478
Closes: #3194

Description

rouille hasn't been updated in a while, and brings with it obsolete dependencies which are either unmaintained or who have CVEs open against them, which is security liability.

This PR switches rouille out for axum, which cuts down on the number of dependencies of the relayer since we already depend on axum via tonic.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac requested a review from ljoss17 March 31, 2023 09:48
@romac romac marked this pull request as ready for review March 31, 2023 09:48
Will implement this in a follow-up PR
Copy link
Contributor

@ljoss17 ljoss17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Cargo.toml Show resolved Hide resolved
@romac romac linked an issue Apr 4, 2023 that may be closed by this pull request
@romac romac merged commit 02e45a7 into master Apr 4, 2023
28 checks passed
@romac romac deleted the romac/rouille-to-axum branch April 4, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants