Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use forked Tonic and Prost #1451

Closed
wants to merge 1 commit into from
Closed

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Oct 11, 2021

Closes: #1161

Description

This is very much a WIP toward replacing tonic with informalsystems-tonic (informalsystems/tonic#1) and prost with informalsystems-prost.

The generated Prost types and Tonic interfaces were generated using our forks.


For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@romac
Copy link
Member

romac commented Oct 27, 2021

Was done in #1166

@romac romac closed this Oct 27, 2021
@romac romac deleted the thane/1161-prost-tonic branch October 27, 2021 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2021-0073: Conversion from prost_types::Timestamp to SystemTime can cause an overflow and panic
2 participants