Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MUI date pickers to v6 #753

Merged
merged 1 commit into from Mar 5, 2024

Conversation

make-github-pseudonymous-again
Copy link
Contributor

Fixes #752. Had to apply workaround found at testing-library/react-testing-library#1248 (comment).

@make-github-pseudonymous-again make-github-pseudonymous-again added ui This issue is about the user interface in general. dependencies Pull requests that update a dependency file deps This issue has to do with dependencies labels Mar 3, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again moved this from Done to In Progress in React@next Mar 3, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again added this to In Progress in MUI@next Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 75.96154% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 66.53%. Comparing base (e2a2bab) to head (0c41f9d).

Files Patch % Lines
imports/i18n/datetime.ts 75.28% 18 Missing and 4 partials ⚠️
imports/api/publication/useTracker.ts 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   66.62%   66.53%   -0.10%     
==========================================
  Files         695      696       +1     
  Lines        9664     9678      +14     
  Branches     1330     1334       +4     
==========================================
  Hits         6439     6439              
- Misses       2735     2746      +11     
- Partials      490      493       +3     
Flag Coverage Δ
test 69.70% <39.21%> (-0.07%) ⬇️
test-app 56.20% <75.96%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixes #752.
Had to upgrade react monorepo.
Had to apply workaround found at
testing-library/react-testing-library#1248 (comment).
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review March 5, 2024 00:15
@make-github-pseudonymous-again make-github-pseudonymous-again moved this from In progress to Done in Continuous Updation Mar 5, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again moved this from In Progress to Done in MUI@next Mar 5, 2024
@make-github-pseudonymous-again make-github-pseudonymous-again moved this from In Progress to Done in React@next Mar 5, 2024
Merged via the queue into main with commit 0b5ed2f Mar 5, 2024
12 checks passed
@make-github-pseudonymous-again make-github-pseudonymous-again deleted the deps-upgrade-react-and-mui-1 branch May 20, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deps This issue has to do with dependencies ui This issue is about the user interface in general.
Development

Successfully merging this pull request may close these issues.

Upgrade @mui/x-date-pickers to v6
1 participant