Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to sarama's new consumer group rebalance strategy setting #12064

Merged
merged 1 commit into from Oct 21, 2022

Conversation

reimda
Copy link
Contributor

@reimda reimda commented Oct 19, 2022

Sarama recently changed the consumer group rebalance strategy setting. I think telegraf updated to a version that uses the new setting in #11980. This PR uses telegraf's existing setting with the new sarama setting.

The old setting is deprecated but it is backward compatible
See IBM/sarama#2352

Although it's backward compatible, sarama logs that a deprecated setting is used, so it is useful to switch to the new setting.

The new setting allows consumers to choose more than one strategy. We may need to add a similar setting to telegraf in the future so users of inputs.kafka can choose which strategies they want instead of being limited to one.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 19, 2022
@telegraf-tiger
Copy link
Contributor

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 20, 2022
@MyaLongmire MyaLongmire merged commit a6352d9 into master Oct 21, 2022
@MyaLongmire MyaLongmire deleted the kafka-rebalance-group-strategies branch October 21, 2022 09:08
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
popey pushed a commit that referenced this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants