Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown support #85

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add markdown support #85

wants to merge 4 commits into from

Conversation

mavarius
Copy link

Add markdown support and storybook styles.

chnn
chnn previously approved these changes Jun 10, 2019
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. I left two comments about some minor administrative stuff.

I think eventually it would be nice to have a non-storybook docs site. Storybook is quick and nice for experimenting, but feels pretty awkward overall as a way to learn a library.

src/styles/_influx-colors.scss Outdated Show resolved Hide resolved
"eslint": "^5.15.3",
"eslint-config-prettier": "^4.1.0",
"eslint-plugin-prettier": "^3.0.1",
"eslint-plugin-react": "^7.12.4",
"jest": "^24.5.0",
"markdown-loader": "^5.0.0",
"marked": "^0.6.2",
"node-sass": "^4.12.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Dart Sass (https://www.npmjs.com/package/sass) instead? node-sass can be a pain to install due to the native deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants