Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gauge mini #382

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

Sciator
Copy link
Contributor

@Sciator Sciator commented Nov 17, 2020

ui#366

Minigauge & Bullet graph

image

Created and developing in Sciator/giraffe-components-concepts runable sandbox.

TODO:

  • All TODOs from Sciator/giraffe-components-concepts
  • Show multiple values
  • Add missing knobs into storybook
  • Swagger
  • Simpler types
  • Giraffe style formaters
  • UI options
  • Feature flag
  • Fix autosizer
  • Docs

@ivankudibal
Copy link
Contributor

Context, contributes to: #198

@Sciator Sciator mentioned this pull request Nov 29, 2020
1 task
@TCL735 TCL735 changed the title feat: gauge mini WIP: feat: gauge mini Dec 18, 2020
@TCL735
Copy link
Contributor

TCL735 commented Dec 18, 2020

Put "WIP" in the title and also unassigning myself and @alexpaxton for now.

@Sciator Sciator changed the title WIP: feat: gauge mini WIP feat: gauge mini Dec 23, 2020
@Sciator Sciator changed the title WIP feat: gauge mini feat: gauge mini WIP Dec 29, 2020
@Sciator Sciator changed the title feat: gauge mini WIP feat: gauge mini Dec 30, 2020
@TCL735
Copy link
Contributor

TCL735 commented Jan 15, 2021

@ivankudibal @Sciator the status of this Pull Request is still "draft". Can you please update the status so that it is not "draft"?

@TCL735
Copy link
Contributor

TCL735 commented Jan 19, 2021

Please remove draft status before re-assigning me to this review. I am still interested in reviewing it, but not while it has the "draft" status.

@TCL735 TCL735 removed their request for review January 19, 2021 20:51
@Sciator Sciator marked this pull request as ready for review January 20, 2021 09:32
@TCL735
Copy link
Contributor

TCL735 commented Jan 22, 2021

@ivankudibal @Sciator - are there product requirements for this feature? I am aware that this is an issue written for Giraffe. However, a repo's issue should either come from a product team's requirements or have some reference to them.

While this looks cool, I would like to review this more objectively by comparing to product requirements.

@ivankudibal
Copy link
Contributor

#198 items 5 and 6

@TCL735
Copy link
Contributor

TCL735 commented Jan 24, 2021

@ivankudibal What I meant was an actual list of product requirements that is outside of any issues in github. I am trying to see where the demand for this feature came from, other than a github issue. As I said, I understand there are issues listed in github with all kinds of different requests. InfluxData has internal discussions regarding what should be developed. I am looking for some sort of insight into that internal discussion. Because so far, I have been unable to find any.

@TCL735
Copy link
Contributor

TCL735 commented Jan 24, 2021

If there are none, and this feature was created just because it got picked by the developer then please give me some more time to review this. This is low priority at the moment.

Give me at least another week. Possibly two weeks.

@timhallinflux
Copy link
Contributor

This is indeed low priority as we work through maps and annotations. Ok to put this on hold until those features land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants