build: fix parcel hang via clean #4075
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces `clean` as the first step in `make dep`, which is the first command run by our CircleCI process. It's not clear why this solves this problem, but a simple yarn run clean, which only rimrafs ./build/* and ./.cache was not preventing parcel from timing out. maybe it was a circle caching problem.
chnn
approved these changes
Aug 1, 2018
|
Seems to be something else, closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces
cleanas the first step inmake dep, whichis the first command run by our CircleCI process. It's not clear
why this solves this problem, or exactly if it solves the problem
to be honest, but the build does pass. A simple
yarn run cleanonlyrimrafs
./build/*and./.cacheand was not preventing parcel fromtiming out. This PR hypothesizes that the problem may be related to
node_modulesand other caching that Circle may do, so we start bycleaning everything.
Aspires to close #4055